Embeded Quote in email with link to quote on line.

[bscunningham]

First, LOVE the new quote functions! THANK YOU!

When sending quotes via email with the option to attach the quote, the email body starts with:

Thank you for requesting a quotation. Please find attached our quotation in accordance with your stated requirements. To view this quote online and accept, partially accept, or reject it, please visit: http://www.spaclique.com/index.php?option=com_nbill&action=quotes&task=edit&cid=9592.

This is fine and I have found the language file where this can modified NBILL_EM_NEW_QUOTE_PAR_1_ATTACHED

We have found that our users prefer the quote to be embedded directly into the email. When using the "Embed the document in the message" option, the default configuration for that does not provide a link back to accept the quote.

It seems like I should be able to just copy the language text from NBILL_EM_NEW_QUOTE_PAR_1_ATTACHED to NBILL_EM_EMBEDDED_QUOTE_INTRO and the link back to the quote should be generated.  But it doesn't look like that language parm is being used in the quote email templates.

I suspect something in the quote email template will need to be modified. I've looked at it but the hack needed is not obvious to me. Does there need to be a new email template "quote_email_default_embed.php" ?

Maybe you could point me in the right direction and save me a bunch of time sorting this out.

Thanks Russel.

[netshine]

Thanks for pointing out this oversight. The embedded option does not use a template, which makes it a bit more difficult to hack. I will fix it for the next release (by adding a new constant which includes the link to accept/reject), but if you want to fudge it in the meantime, you would need to hack the /administrator/components/com_nbill/framework/classes/nbill.email.class.php file around line 426 where it says:

$footer .= "<br /><br />" . NBILL_EM_REGARDS . "<br />" . nbf_cms::$interop->site_name;

...replace with:

$url = nbf_cms::$interop->live_site . "/" . nbf_cms::$interop->site_page_prefix . "&action=quotes&task=view&id=" . $document->id;
$footer .= "<br /><br />To view your quote online and accept, partially accept, or reject it, please visit: <a href=\"$url\">$url</a>";
$footer .= "<br /><br />" . NBILL_EM_REGARDS . "<br />" . nbf_cms::$interop->site_name;

This is just a temporary measure (I would not normally recommend hard-coding text like that!) - it is probably safer to hard code the text rather than insert a new constant in the language file yourself because if I need to add any further constants to the language file, you could miss out on them during the upgrade otherwise (as the upgrader may think you already have the latest additions).

[netshine]

Ooops - just noticed, the email class file is ionCube encoded. There is no real need for it to be, so attached is an unencoded copy of the version 2.0.9 file.

[attachment deleted by admin]

[bscunningham]

Thanks that works except how can I get that message to appear above the quote?

Would it be:?


$footer .= "<br /><br />To view your quote online and accept, partially accept, or reject it, please visit: <a href=\"$url\">$url</a>";
$url = nbf_cms::$interop->live_site . "/" . nbf_cms::$interop->site_page_prefix . "&action=quotes&task=view&id=" . $document->id;
$footer .= "<br /><br />" . NBILL_EM_REGARDS . "<br />" . nbf_cms::$interop->site_name;

[netshine]

No, you would need to modify line 417 where it says:

$embedded_message .= NBILL_EM_EMBEDDED_QUOTE_INTRO;

...and change it to:

$embedded_message .= NBILL_EM_EMBEDDED_QUOTE_INTRO;
$url = nbf_cms::$interop->live_site . "/" . nbf_cms::$interop->site_page_prefix . "&action=quotes&task=view&id=" . $document->id;
$embedded_message .= "<br /><br />To view your quote online and accept, partially accept, or reject it, please visit: <a href=\"$url\">$url</a>";

I will think about whether to introduce a template or some other mechanism for embedded documents to make it more flexible in future.

[bscunningham]

Hey, We are just upgrading to 2.0.9. where /administrator/components/com_nbill/framework/classes/nbill.email.class.php is still encrypted.

Can you tell me if it has been modified since this discussion? In other words is it safe to just upload my 2.0.7 version? Normally we'd just do a kDiff on the two version but since it's encrypted....... 

[netshine]

The file attached above is the 2.0.9 version, unencrypted.

[bscunningham]

Thanks. It seems they are the same.

[bscunningham]

Thanks. It seems they are the same.

Thanks for pointing out this oversight. The embedded option does not use a template, which makes it a bit more difficult to hack. I will fix it for the next release (by adding a new constant which includes the link to accept/reject),

Maybe next release?

[netshine]

It is still the same because it is the version 2.0.9 file, and version 2.0.9 was released before you started this thread - there have been no new stable releases since then. A link to accept/reject has been added in 2.1.0 beta (which is available now), and of course will also be present in 2.1.1 stable (which I am hoping to release this month). Don't just replace the 2.0.9 email class file with the 2.1.0 one though, as that will not work.

[bscunningham]

It is still the same because it is the version 2.0.9 file, and version 2.0.9

So it is.....

[attachment deleted by admin]